Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few improvements to the core::hash top-level docs. #40505

Merged
merged 1 commit into from Mar 17, 2017
Merged

A few improvements to the core::hash top-level docs. #40505

merged 1 commit into from Mar 17, 2017

Conversation

frewsxcv
Copy link
Member

Primarily opened to address the concerns brought up in
#40498.

  • run rustfmt on code blocks
  • use DefaultHasher instead of deprecated SipHasher
  • rename hash to calculate_hash to prevent confusion with the hash
    method

@frewsxcv
A few improvements to the core::hash top-level docs.
5cc056a 
Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv mentioned this pull request Mar 14, 2017
Closed
@alexcrichton
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit 5cc056a has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 15, 2017
@frewsxcv
Rollup merge of rust-lang#40505 - frewsxcv:hash-docs, r=alexcrichton
cc1e513 
A few improvements to the `core::hash` top-level docs.

Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@frewsxcv frewsxcv mentioned this pull request Mar 15, 2017
Closed
bors added a commit that referenced this pull request Mar 15, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
b5ccda0 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
bors added a commit that referenced this pull request Mar 16, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
d62dea5 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40505 - frewsxcv:hash-docs, r=alexcrichton
5c3e066 
A few improvements to the `core::hash` top-level docs.

Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40505 - frewsxcv:hash-docs, r=alexcrichton
7459aa8 
A few improvements to the `core::hash` top-level docs.

Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40505 - frewsxcv:hash-docs, r=alexcrichton
a463ba8 
A few improvements to the `core::hash` top-level docs.

Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40505 - frewsxcv:hash-docs, r=alexcrichton
7a71d64 
A few improvements to the `core::hash` top-level docs.

Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40505 - frewsxcv:hash-docs, r=alexcrichton
f47a377 
A few improvements to the `core::hash` top-level docs.

Primarily opened to address the concerns brought up in
rust-lang#40498.

* run rustfmt on code blocks
* use `DefaultHasher` instead of deprecated `SipHasher`
* rename `hash` to `calculate_hash` to prevent confusion with the `hash`
  method
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Merged
bors added a commit that referenced this pull request Mar 17, 2017
@bors
Auto merge of #40598 - frewsxcv:rollup, r=frewsxcv
a559452 
Rollup of 23 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40458, #40463, #40466, #40467, #40495, #40496, #40497, #40499, #40500, #40503, #40505, #40512, #40514, #40517, #40520, #40536, #40545, #40586
- Failed merges:
@bors bors merged commit 5cc056a into rust-lang:master Mar 17, 2017
@frewsxcv frewsxcv deleted the hash-docs branch March 20, 2017 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frewsxcv @rust-highfive @alexcrichton @bors