Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to run rustbuild on low priority on Windows #40776

Closed
wants to merge 2 commits into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 23, 2017

Just so I can watch YouTube videos while compiling

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa
Copy link
Member

nagisa commented Apr 7, 2017

Similar effect can be achieved on unix by setting the nice level. See setrlimit(2) RLIMIT_NICE.

@alexcrichton
Copy link
Member

I personally feel like this is slightly weird to implement in a build system, but with a relatively clear implementation path on Unix then if we are to have it at all I feel like we should put in the extra effort to implement this on Unix as well.

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2017
@carols10cents
Copy link
Member

Hi @Zoxc! This looks awesome! 😆 Are you up for making the changes for Unix as well, or could you use some help with that?

@carols10cents
Copy link
Member

Hi @Zoxc, since we haven't heard back from you about whether you're willing and able to make the changes requested to support Unix as well, we’re going to close this for now. When you get a chance to update this or let us know that you need help, please reopen!

QuietMisdreavus pushed a commit to QuietMisdreavus/rust that referenced this pull request May 16, 2017
This is a resurrection of rust-lang#40776, combining their Windows setup with an
additional setup on Unix to set the program group's niceness to +10
(low-but-not-lowest priority) when the `low_priority` option is on.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 18, 2017
…hton

Add an option to run rustbuild on low priority on Windows and Unix

This is a resurrection of rust-lang#40776, combining their Windows setup with an additional setup on Unix to set the program group's *nice*ness to +10 (low-but-not-lowest priority, mirroring the priority in the Windows setup) when the `low_priority` option is on.
bors added a commit that referenced this pull request May 20, 2017
Add an option to run rustbuild on low priority on Windows and Unix

This is a resurrection of #40776, combining their Windows setup with an additional setup on Unix to set the program group's *nice*ness to +10 (low-but-not-lowest priority, mirroring the priority in the Windows setup) when the `low_priority` option is on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants