-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Use poll
instead of select
#41039
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
r=me |
I think you might need libc::POLLERR and libc::POLLHUP as well? |
According to the poll man page:
So in that sense I don't think we need to ask for them explicitly? I originally had them in but removed them due to that clause. @bors r=nagisa |
📌 Commit 47c6187 has been approved by |
47c6187
to
47e8f3b
Compare
@bors: r=nagisa |
📌 Commit 47e8f3b has been approved by |
This gives us the benefit of supporting file descriptors over the limit that select supports, which... Closes rust-lang#40894
47e8f3b
to
8c01ce3
Compare
@bors: r=nagisa |
📌 Commit 8c01ce3 has been approved by |
std: Use `poll` instead of `select` This gives us the benefit of supporting file descriptors over the limit that select supports, which... Closes #40894
☀️ Test successful - status-appveyor, status-travis |
This gives us the benefit of supporting file descriptors over the limit that
select supports, which...
Closes #40894