Skip to content

Conversation

sirideain
Copy link
Contributor

Fixes #28848

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aturon
Copy link
Contributor

aturon commented May 3, 2017

Looks great, thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 3, 2017

📌 Commit df5ab64 has been approved by aturon

@bors
Copy link
Collaborator

bors commented May 3, 2017

⌛ Testing commit df5ab64 with merge 8305394...

bors added a commit that referenced this pull request May 3, 2017
Add test for Inherent static methods

Fixes #28848
@bors
Copy link
Collaborator

bors commented May 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 8305394 to master...

@bors bors merged commit df5ab64 into rust-lang:master May 3, 2017
@sirideain sirideain deleted the add-static-methods-test branch May 3, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants