Delete features which are easily removed, in libsyntax

[strega-nil]

No description provided.

[rust-highfive]

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

[aidanhs]

Hi @ubsan, looks like this has failed travis because the Cargo.lock needs updating as well?

[strega-nil]

@aidanhs ah, dang

[strega-nil]

Hopefully that fixes it.

[emilio]

nit: indentation is weird here.

[strega-nil]

oh, right, I use a different style from rustc.

[kennytm]

Could some features from libsyntax_pos (a dependency of libsyntax) be removed as well?

/rust/src/libsyntax_pos$ git grep '\[feature'
lib.rs:26:#![feature(const_fn)]
lib.rs:27:#![feature(custom_attribute)]
lib.rs:28:#![feature(optin_builtin_traits)]
lib.rs:30:#![feature(rustc_private)]
lib.rs:31:#![feature(staged_api)]
lib.rs:32:#![feature(specialization)]

[strega-nil]

@kennytm it's a lot harder. The only one you can delete without changing quite a bit of code is specialization, which can just be deleted.

[kennytm]

@ubsan I see, thanks. I thought they are pulled in also due to bitflags.

[Mark-Simulacrum]

I think this is done, though commits could be squashed.

[strega-nil]

@Mark-Simulacrum done

[nrc]

@bors: r+

[bors]

📌 Commit 0be8758 has been approved by nrc

[bors]

⌛ Testing commit 0be8758 with merge 9956e81...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 9956e81 to master...