Fix regression introduced by jQuery removal #42080
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -215,14 +215,14 @@ | |||
| } else if (ev.target.tagName === 'SPAN' && hasClass(ev.target.parentNode, 'line-numbers')) { | |||
| var prev_id = 0; | |||
|
|
|||
| function set_fragment(name) { | |||
There was a problem hiding this comment.
Because ES5 does not allow function declaration here.
There was a problem hiding this comment.
it's not clear to me why ES5 wouldn't accept this, but not a big deal, seems fine to me
There was a problem hiding this comment.
For example: http://stackoverflow.com/a/25111212
There was a problem hiding this comment.
oh interesting! wasn't aware of that detail, thanks for sharing!
| @@ -685,7 +685,7 @@ | |||
| } | |||
|
|
|||
| function escape(content) { | |||
| let h1 = document.createElement('h1'); | |||
There was a problem hiding this comment.
out of curiosity, which browser are you using that doesn't support let?
There was a problem hiding this comment.
Opera 12 is from 2012, so that makes sense. 😅 I don't mind making this change, as it's pretty small, but it is very unlikely that we won't end up doing something that breaks it in the future.
|
@bors r+ rollup |
|
📌 Commit 1eb6639 has been approved by |
alexcrichton
added
the
S-waiting-on-bors
Fix regression introduced by jQuery removal Fixes rust-lang#42078. Follows rust-lang#41307. r? @steveklabnik cc @frewsxcv
Fix regression introduced by jQuery removal Fixes rust-lang#42078. Follows rust-lang#41307. r? @steveklabnik cc @frewsxcv
Fix regression introduced by jQuery removal Fixes rust-lang#42078. Follows rust-lang#41307. r? @steveklabnik cc @frewsxcv
Fix regression introduced by jQuery removal Fixes rust-lang#42078. Follows rust-lang#41307. r? @steveklabnik cc @frewsxcv
Fixes #42078.
Follows #41307.
r? @steveklabnik
cc @frewsxcv