Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building std without backtrace feature, which was broken in ca8b754 #42141

Merged
merged 1 commit into from
May 25, 2017
Merged

Fix building std without backtrace feature, which was broken in ca8b754 #42141

merged 1 commit into from
May 25, 2017

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented May 21, 2017

Fixes #42139

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2017
@carols10cents
Copy link
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @aturon or someone else from the team reviews it soon.

@aturon
Copy link
Member

aturon commented May 23, 2017

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 23, 2017

📌 Commit 66237af has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017
@frewsxcv
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
057761c 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@frewsxcv frewsxcv mentioned this pull request May 24, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017
@frewsxcv
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
078b253 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@frewsxcv frewsxcv mentioned this pull request May 24, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
0c3bc8d 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 24, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
9fdb2f6 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 24, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
5334b0d 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 24, 2017
Closed
bors added a commit that referenced this pull request May 24, 2017
@bors
Auto merge of #42203 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
5f7b330 
Rollup of 16 pull requests

- Successful merges: #41700, #41980, #42052, #42071, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191, #42195, #42198
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
f60da49 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 25, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42141 - ids1024:nobacktrace, r=aturon
8bac98a 
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 25, 2017
Merged
bors added a commit that referenced this pull request May 25, 2017
@bors
Auto merge of #42212 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
cf747fc 
Rollup of 15 pull requests

- Successful merges: #41980, #42071, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191, #42195, #42198, #42211
- Failed merges:
@bors bors merged commit 66237af into rust-lang:master May 25, 2017
@ids1024 ids1024 deleted the nobacktrace branch June 23, 2017 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ids1024 @rust-highfive @carols10cents @aturon @bors