Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement requires_synchronized_create() for Redox #42142

Merged
merged 1 commit into from
May 25, 2017

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented May 21, 2017

This was breaking the libstd build for Redox.

This was breaking the libstd build for Redox.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents
Copy link
Member

Looks like an intermittent travis problem; I've restarted the job.

We'll check in on this to make sure this PR gets through CI and gets reviewed!! Thank you!!

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2017
@aturon
Copy link
Member

aturon commented May 24, 2017

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 24, 2017

📌 Commit f4147e5 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
bors added a commit that referenced this pull request May 24, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
bors added a commit that referenced this pull request May 25, 2017
@bors bors merged commit f4147e5 into rust-lang:master May 25, 2017
@ids1024 ids1024 deleted the redox branch October 5, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants