New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement requires_synchronized_create() for Redox #42142

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
5 participants
@ids1024
Contributor

ids1024 commented May 21, 2017

This was breaking the libstd build for Redox.

Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented May 21, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents

This comment has been minimized.

Member

carols10cents commented May 22, 2017

Looks like an intermittent travis problem; I've restarted the job.

We'll check in on this to make sure this PR gets through CI and gets reviewed!! Thank you!!

@aturon

This comment has been minimized.

Member

aturon commented May 24, 2017

@bors: r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented May 24, 2017

📌 Commit f4147e5 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

bors added a commit that referenced this pull request May 24, 2017

Auto merge of #42185 - frewsxcv:rollup, r=frewsxcv
Rollup of 8 pull requests

- Successful merges: #42081, #42109, #42120, #42141, #42142, #42159, #42169, #42177
- Failed merges:

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

bors added a commit that referenced this pull request May 24, 2017

Auto merge of #42193 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 14 pull requests

- Successful merges: #41932, #41980, #42071, #42083, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191
- Failed merges:

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

bors added a commit that referenced this pull request May 24, 2017

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

bors added a commit that referenced this pull request May 25, 2017

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017

Rollup merge of rust-lang#42142 - ids1024:redox, r=aturon
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.

bors added a commit that referenced this pull request May 25, 2017

Auto merge of #42212 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 15 pull requests

- Successful merges: #41980, #42071, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191, #42195, #42198, #42211
- Failed merges:

@bors bors merged commit f4147e5 into rust-lang:master May 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ids1024 ids1024 deleted the ids1024:redox branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment