New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize non capturing closure to fn coercion #42162

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@est31
Contributor

est31 commented May 23, 2017

Stabilisation PR for non capturing closure to fn coercion.

closes #39817

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive May 23, 2017

Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented May 23, 2017

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 23, 2017

Contributor

☔️ The latest upstream changes (presumably #42165) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented May 23, 2017

☔️ The latest upstream changes (presumably #42165) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 25, 2017

Contributor

☔️ The latest upstream changes (presumably #41145) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented May 25, 2017

☔️ The latest upstream changes (presumably #41145) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik May 26, 2017

Member

all the other criteria needed for stabilisation are met.

Docs criteria is met.

Member

steveklabnik commented May 26, 2017

all the other criteria needed for stabilisation are met.

Docs criteria is met.

@est31

This comment has been minimized.

Show comment
Hide comment
@est31

est31 May 26, 2017

Contributor

As agreed to on IRC, asking for early review (before the remaining 7 days of FCP are over) due to the branch date of beta in 7 days, otherwise the feature might not make it into 1.19. We can always back out later.

r? @aturon

Contributor

est31 commented May 26, 2017

As agreed to on IRC, asking for early review (before the remaining 7 days of FCP are over) due to the branch date of beta in 7 days, otherwise the feature might not make it into 1.19. We can always back out later.

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned pnkfelix May 26, 2017

@aturon

This comment has been minimized.

Show comment
Hide comment
@aturon

aturon May 27, 2017

Member

Let's go ahead and get this into the queue.

@bors: r+

Member

aturon commented May 27, 2017

Let's go ahead and get this into the queue.

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 27, 2017

Contributor

📌 Commit 87950b7 has been approved by aturon

Contributor

bors commented May 27, 2017

📌 Commit 87950b7 has been approved by aturon

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017

Rollup merge of #42162 - est31:closure-to-fn-coercion, r=aturon
Stabilize non capturing closure to fn coercion

Stabilisation PR for non capturing closure to fn coercion.

closes #39817

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017

Rollup merge of #42162 - est31:closure-to-fn-coercion, r=aturon
Stabilize non capturing closure to fn coercion

Stabilisation PR for non capturing closure to fn coercion.

closes #39817

bors added a commit that referenced this pull request May 27, 2017

Auto merge of #42258 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 10 pull requests

- Successful merges: #42103, #42137, #42162, #42167, #42175, #42207, #42217, #42246, #42249, #42251
- Failed merges:
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 27, 2017

Contributor

⌛️ Testing commit 87950b7 with merge 5d2512e...

Contributor

bors commented May 27, 2017

⌛️ Testing commit 87950b7 with merge 5d2512e...

bors added a commit that referenced this pull request May 27, 2017

Auto merge of #42162 - est31:closure-to-fn-coercion, r=aturon
Stabilize non capturing closure to fn coercion

Stabilisation PR for non capturing closure to fn coercion.

closes #39817
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 28, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 5d2512e to master...

Contributor

bors commented May 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 5d2512e to master...

@est31

This comment has been minimized.

Show comment
Hide comment
@est31

est31 May 28, 2017

Contributor

It got merged yeey!

I'm not sure though why the PR doesn't get shown as "merged" by this. Github bug?

Contributor

est31 commented May 28, 2017

It got merged yeey!

I'm not sure though why the PR doesn't get shown as "merged" by this. Github bug?

@est31 est31 closed this May 28, 2017

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum May 28, 2017

Member

GH seems to recognize that it is merged afterwards though; I can't reopen -- "commits are already merged"

Member

Mark-Simulacrum commented May 28, 2017

GH seems to recognize that it is merged afterwards though; I can't reopen -- "commits are already merged"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment