New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redox build, broken in ecbb896b9eb2acadefde57be493e4298c1aa04a3 #42848

Merged
merged 1 commit into from Jun 29, 2017

Conversation

Projects
None yet
7 participants
@ids1024
Contributor

ids1024 commented Jun 23, 2017

No description provided.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jun 23, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster

This comment has been minimized.

Member

shepmaster commented Jun 23, 2017

Thanks @ids1024! We'll wrangle up a @brson or other wonderful reviewer shortly!

@aidanhs

This comment has been minimized.

Member

aidanhs commented Jun 28, 2017

r? @sfackler
(since it's your commit and you've reviewed redox PRs before)

@aidanhs aidanhs assigned sfackler and unassigned brson Jun 28, 2017

@sfackler

This comment has been minimized.

Member

sfackler commented Jun 29, 2017

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Jun 29, 2017

📌 Commit 87f6d62 has been approved by sfackler

@bors

This comment has been minimized.

Contributor

bors commented Jun 29, 2017

⌛️ Testing commit 87f6d62 with merge dc2003b...

bors added a commit that referenced this pull request Jun 29, 2017

@bors

This comment has been minimized.

Contributor

bors commented Jun 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing dc2003b to master...

@bors bors merged commit 87f6d62 into rust-lang:master Jun 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ids1024 ids1024 deleted the ids1024:redox-fix branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment