New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redox: Use O_NOFOLLOW for lstat() #43056
Conversation
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks for the PR @ids1024, we'll make sure @BurntSushi or another reviewer gets to this soon! |
@@ -447,7 +447,10 @@ pub fn stat(p: &Path) -> io::Result<FileAttr> { | |||
} | |||
|
|||
pub fn lstat(p: &Path) -> io::Result<FileAttr> { | |||
stat(p) | |||
let fd = cvt(syscall::open(p.to_str().unwrap(), | |||
syscall::O_CLOEXEC | syscall::O_STAT | syscall::O_NOFOLLOW))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this should probably also specify O_RDONLY
to obey posix (since redox seems to be posixish).
(it's an interesting dilemma whether redox should reject that syscall as-is - it's technically invalid, but linux would accept it because O_RDONLY
is defined as 0, so is always implicit. In redox it's defined as 1, so there's a choice between correctness and Linux program compatibility)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False. O_STAT
in Redox allows a file handle to be opened on a file without read permission, if the user has the ability to read the directory. This file handle can only be used for things like fstat
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see O_STAT
is not posix, I guess that justifies my 'ish' in 'posixish'. Thanks for the clarification.
Hi @BurntSushi - are you going to be reviewing this? Should someone else be reviewing it? Just trying to keep it going. |
📌 Commit 4e26908 has been approved by |
🔒 Merge conflict |
@bors: r=burntsushi |
📌 Commit 51260f4 has been approved by |
Redox: Use O_NOFOLLOW for lstat()
☀️ Test successful - status-appveyor, status-travis |
No description provided.