New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redox: Use O_NOFOLLOW for lstat() #43056

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
8 participants
@ids1024
Contributor

ids1024 commented Jul 4, 2017

No description provided.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jul 4, 2017

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs

This comment has been minimized.

Member

aidanhs commented Jul 5, 2017

Thanks for the PR @ids1024, we'll make sure @BurntSushi or another reviewer gets to this soon!

@@ -447,7 +447,10 @@ pub fn stat(p: &Path) -> io::Result<FileAttr> {
}

pub fn lstat(p: &Path) -> io::Result<FileAttr> {
stat(p)
let fd = cvt(syscall::open(p.to_str().unwrap(),
syscall::O_CLOEXEC | syscall::O_STAT | syscall::O_NOFOLLOW))?;

This comment has been minimized.

@aidanhs

aidanhs Jul 7, 2017

Member

FWIW this should probably also specify O_RDONLY to obey posix (since redox seems to be posixish).

(it's an interesting dilemma whether redox should reject that syscall as-is - it's technically invalid, but linux would accept it because O_RDONLY is defined as 0, so is always implicit. In redox it's defined as 1, so there's a choice between correctness and Linux program compatibility)

This comment has been minimized.

@jackpot51

jackpot51 Jul 8, 2017

Contributor

False. O_STAT in Redox allows a file handle to be opened on a file without read permission, if the user has the ability to read the directory. This file handle can only be used for things like fstat.

This comment has been minimized.

@aidanhs

aidanhs Jul 9, 2017

Member

Ah I see O_STAT is not posix, I guess that justifies my 'ish' in 'posixish'. Thanks for the clarification.

@arielb1

This comment has been minimized.

Contributor

arielb1 commented Jul 11, 2017

Hi @BurntSushi - are you going to be reviewing this? Should someone else be reviewing it? Just trying to keep it going.

@BurntSushi

This comment has been minimized.

Member

BurntSushi commented Jul 11, 2017

@arielb1 Ah thanks, I missed this.

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Jul 11, 2017

📌 Commit 4e26908 has been approved by BurntSushi

@bors

This comment has been minimized.

Contributor

bors commented Jul 11, 2017

🔒 Merge conflict

@ids1024 ids1024 force-pushed the ids1024:nofollow2 branch from 4e26908 to 51260f4 Jul 11, 2017

@aturon

This comment has been minimized.

Member

aturon commented Jul 11, 2017

@bors: r=burntsushi

@bors

This comment has been minimized.

Contributor

bors commented Jul 11, 2017

📌 Commit 51260f4 has been approved by burntsushi

@bors

This comment has been minimized.

Contributor

bors commented Jul 12, 2017

⌛️ Testing commit 51260f4 with merge cd71ea7...

bors added a commit that referenced this pull request Jul 12, 2017

Auto merge of #43056 - ids1024:nofollow2, r=burntsushi
Redox: Use O_NOFOLLOW for lstat()
@bors

This comment has been minimized.

Contributor

bors commented Jul 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: burntsushi
Pushing cd71ea7 to master...

@bors bors merged commit 51260f4 into rust-lang:master Jul 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ids1024 ids1024 deleted the ids1024:nofollow2 branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment