Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM] Fix an assertion when a weak symbol is defined in global_asm. #43313

Merged
merged 1 commit into from
Jul 21, 2017
Merged

[LLVM] Fix an assertion when a weak symbol is defined in global_asm. #43313

merged 1 commit into from
Jul 21, 2017

Conversation

pftbest
Copy link
Contributor

@pftbest pftbest commented Jul 18, 2017

This change will fix the issue from
rust-embedded/svd2rust#130

cc @japaric
r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 18, 2017

📌 Commit 9b8c223 has been approved by alexcrichton

@japaric
Copy link
Member

japaric commented Jul 18, 2017

Wow, that was fast. ❤️ @pftbest

@japaric japaric mentioned this pull request Jul 18, 2017
Merged
@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 18, 2017
@bors
Copy link
Contributor

bors commented Jul 19, 2017

⌛ Testing commit 9b8c223 with merge 174ba0164f5bbf38964d11454517800640313b59...

@bors
Copy link
Contributor

bors commented Jul 19, 2017

💔 Test failed - status-appveyor

@pftbest
Copy link
Contributor Author

pftbest commented Jul 19, 2017

SSL connect error?

@alexcrichton
Copy link
Member

alexcrichton commented Jul 19, 2017 via email

@japaric japaric mentioned this pull request Jul 20, 2017
Closed
@bors
Copy link
Contributor

bors commented Jul 20, 2017

⌛ Testing commit 9b8c223 with merge 2d30351020147725bd5bc81d9478e744a2c70869...

@bors
Copy link
Contributor

bors commented Jul 20, 2017

💔 Test failed - status-travis

@TimNN
Copy link
Contributor

TimNN commented Jul 21, 2017

@bors retry

  • Mac Builder did not start.

TimNN added a commit to TimNN/rust that referenced this pull request Jul 21, 2017
@TimNN
Rollup merge of rust-lang#43313 - pftbest:fix_asm, r=alexcrichton
e6ef4b9 
[LLVM] Fix an assertion when a weak symbol is defined in global_asm.

This change will fix the issue from
rust-embedded/svd2rust#130

cc @japaric
r? @alexcrichton
@TimNN TimNN mentioned this pull request Jul 21, 2017
Closed
bors added a commit that referenced this pull request Jul 21, 2017
@bors
Auto merge of #43388 - TimNN:rollup, r=TimNN
bf51b85 
Rollup of 8 pull requests

- Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343
- Failed merges:
@bors
Copy link
Contributor

bors commented Jul 21, 2017

⌛ Testing commit 9b8c223 with merge 6c94965...

bors added a commit that referenced this pull request Jul 21, 2017
@bors
Auto merge of #43313 - pftbest:fix_asm, r=alexcrichton
6c94965 
[LLVM] Fix an assertion when a weak symbol is defined in global_asm.

This change will fix the issue from
rust-embedded/svd2rust#130

cc @japaric
r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jul 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6c94965 to master...

@bors bors merged commit 9b8c223 into rust-lang:master Jul 21, 2017
@pftbest pftbest deleted the fix_asm branch July 23, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pftbest @rust-highfive @alexcrichton @bors @japaric @TimNN @arielb1