Skip to content

Conversation

pczarn
Copy link
Contributor

@pczarn pczarn commented Jul 23, 2017

The macro parser is described as an NFA, not an Earley parser.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@pczarn pczarn force-pushed the macro-parser-description branch from d1e2737 to 7812b6f Compare July 23, 2017 16:58
@pczarn pczarn force-pushed the macro-parser-description branch from 7812b6f to 3467176 Compare July 24, 2017 11:57
@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2017
@alexcrichton
Copy link
Member

r? @jseyfried

Mind taking a look at this @jseyfried? I think @pnkfelix is on PTO right now and may be unable to review.

@rust-highfive rust-highfive assigned jseyfried and unassigned pnkfelix Jul 27, 2017
@jseyfried
Copy link
Contributor

@pczarn Thanks! Most of the code in libsyntax/ext/tt is very old; cleanups are especially welcome :)

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 28, 2017

📌 Commit 3467176 has been approved by jseyfried

@bors
Copy link
Collaborator

bors commented Jul 28, 2017

⌛ Testing commit 3467176 with merge a9a0707...

bors added a commit that referenced this pull request Jul 28, 2017
Make the macro parser theory description more accurate

The macro parser is described as an NFA, not an Earley parser.
@bors
Copy link
Collaborator

bors commented Jul 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jseyfried
Pushing a9a0707 to master...

@bors bors merged commit 3467176 into rust-lang:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants