Implement Clone only for Copy types.
#44196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
approved these changes
Aug 31, 2017
|
Also, did it reach beta? It'd have to be reverted there too if it did. |
eddyb
added
the
beta-nominated
|
Well, the PR looks good to me. I'd be ok with landing this (and perhaps reverting it) pending resolution of rust-lang/rfcs#2132 and rust-lang/rfcs#2133. That said, the trait selection code looks overall less clean to me, so that's a downside (although not having to handle |
|
☔ The latest upstream changes (presumably #44154) made this pull request unmergeable. Please resolve the merge conflicts. |
shepmaster
added
the
S-waiting-on-author
|
I think we can close this due to the RFCs being in FCP. |
|
Removing beta nomination as this is closed |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ICEs encountered in e.g. #28229, no less, no more. I removed the old code as it will still be available in the commit history (or in my own branch).
cc @arielb1 @eddyb
r? @nikomatsakis