Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Remove invalid doctest from bootstrap.py #44268

Merged
merged 1 commit into from Sep 4, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Sep 2, 2017

No description provided.

@Mark-Simulacrum
Copy link
Member

@bors r+ -- I think I recently saw this fail on Travis, too, but the overall build didn't fail. Did you see the doctests failing locally and stopping the build in the entirety?

@bors
Copy link
Contributor

bors commented Sep 2, 2017

📌 Commit 5499d2b has been approved by Mark-Simulacrum

@kennytm
Copy link
Member Author

kennytm commented Sep 2, 2017

@Mark-Simulacrum I just find it annoying that the failing test appear before make tidy 😄

The strange thing is that even if the test failed, the return code is still 0 (success), so while it should stop the build, it doesn't. Also, I expect the content should be collapsed between check-bootstrap in Travis, but it is still appearing 😕. I may push a new commit to fix that.

Make sure that if the test is failed, the CI will stop the build.
@kennytm
Copy link
Member Author

kennytm commented Sep 2, 2017

@Mark-Simulacrum OK now the check-bootstrap should properly detect if all tests are successful, and stop the CI on failure. Also content is now properly collapsed in Travis.

@Mark-Simulacrum
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 2, 2017

📌 Commit 4d06185 has been approved by Mark-Simulacrum

@kennytm
Copy link
Member Author

kennytm commented Sep 2, 2017

@bors rollup (pretty sure it won't interfere other Rust code)

@bors
Copy link
Contributor

bors commented Sep 4, 2017

⌛ Testing commit 4d06185 with merge e22a3cf...

bors added a commit that referenced this pull request Sep 4, 2017
…lacrum

rustbuild: Remove invalid doctest from bootstrap.py
@bors
Copy link
Contributor

bors commented Sep 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing e22a3cf to master...

@bors bors merged commit 4d06185 into rust-lang:master Sep 4, 2017
@kennytm kennytm deleted the fix-python-bootstrap-test branch September 4, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants