New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TcpStream::local_addr docs example code #44913

Merged
merged 2 commits into from Oct 7, 2017

Conversation

Projects
None yet
6 participants
@leavehouse
Contributor

leavehouse commented Sep 29, 2017

The local address's port is not 8080 in this example, that's the remote peer address port. On my machine, the local address is different every time, so I've changed assert_eq to only test the IP address

Fix TcpStream::local_addr example code
The local address's port is not 8080 in this example, that's the remote peer address port. On my machine, the local address is different every time, so I've changed `assert_eq` to only test the IP address
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 29, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Sep 29, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Fix imports in TcpStream::local_addr docs example
Add a missing import and remove unused imports
@shepmaster

This comment has been minimized.

Show comment
Hide comment
@shepmaster

shepmaster Sep 29, 2017

Member

Thanks, @leavehouse! We'll get our crack team of reviewers on this shortly!

Member

shepmaster commented Sep 29, 2017

Thanks, @leavehouse! We'll get our crack team of reviewers on this shortly!

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Oct 6, 2017

Member

Seems reasonable to me! @bors r+

Member

BurntSushi commented Oct 6, 2017

Seems reasonable to me! @bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 6, 2017

Contributor

📌 Commit 6482ee7 has been approved by BurntSushi

Contributor

bors commented Oct 6, 2017

📌 Commit 6482ee7 has been approved by BurntSushi

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 7, 2017

Contributor

⌛️ Testing commit 6482ee7 with merge bb4d149...

Contributor

bors commented Oct 7, 2017

⌛️ Testing commit 6482ee7 with merge bb4d149...

bors added a commit that referenced this pull request Oct 7, 2017

Auto merge of #44913 - leavehouse:patch-1, r=BurntSushi
Fix TcpStream::local_addr docs example code

The local address's port is not 8080 in this example, that's the remote peer address port. On my machine, the local address is different every time, so I've changed `assert_eq` to only test the IP address
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 7, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing bb4d149 to master...

Contributor

bors commented Oct 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing bb4d149 to master...

@bors bors merged commit 6482ee7 into rust-lang:master Oct 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment