New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document trait impls when the type appears in the trait's generics #44969

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
6 participants
@QuietMisdreavus
Member

QuietMisdreavus commented Oct 2, 2017

Fixes #25264

image

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 2, 2017

Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Oct 2, 2017

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Oct 5, 2017

Member

Iiinteresting. I like it, would like to see what others say.

Member

steveklabnik commented Oct 5, 2017

Iiinteresting. I like it, would like to see what others say.

@QuietMisdreavus

This comment has been minimized.

Show comment
Hide comment
@QuietMisdreavus

QuietMisdreavus Oct 5, 2017

Member

I guess we should properly tag @rust-lang/docs to pull in the others, in that case.

Member

QuietMisdreavus commented Oct 5, 2017

I guess we should properly tag @rust-lang/docs to pull in the others, in that case.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 5, 2017

Member

Wo, that's awesome! Huge 👍 for me!

Member

GuillaumeGomez commented Oct 5, 2017

Wo, that's awesome! Huge 👍 for me!

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Oct 11, 2017

Member

@bors: r+

everyone is happy with this!

Member

steveklabnik commented Oct 11, 2017

@bors: r+

everyone is happy with this!

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 11, 2017

Contributor

📌 Commit 23f5fbe has been approved by steveklabnik

Contributor

bors commented Oct 11, 2017

📌 Commit 23f5fbe has been approved by steveklabnik

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 12, 2017

Contributor

⌛️ Testing commit 23f5fbe with merge fbb5054...

Contributor

bors commented Oct 12, 2017

⌛️ Testing commit 23f5fbe with merge fbb5054...

bors added a commit that referenced this pull request Oct 12, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 12, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing fbb5054 to master...

Contributor

bors commented Oct 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing fbb5054 to master...

@bors bors merged commit 23f5fbe into rust-lang:master Oct 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus:impls-for-everyone branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment