Fix a bug in diagnostics for x as usize < y
#45146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve diagnostics for `x as usize << y`
|
I feel that the macro error has room for improvement, we need to come up with an appropriate output for cases where the parser goes awry inside macros. @bors r+ rollup |
|
📌 Commit 3e4d9df has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 10, 2017
Fix a bug in diagnostics for `x as usize < y` Also improve diagnostics for `x as usize << y`. Fixes rust-lang#44406 r? @estebank
bors
added a commit
that referenced
this pull request
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve diagnostics for
x as usize << y.Fixes #44406
r? @estebank