Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add nested groups in imports #45846
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Ok, I did a bit more work on this PR today:
I feel like the PR is almost ready to be fully reviewed and merged now. The only thing missing is that nasty failing test about proc macros, but I can't seem to find out why it fails...
added a commit
this pull request
Nov 30, 2017
Of course, rustfmt is broken.
It's also desirable to send a PR to rustfmt fixing the breakage.