Skip to content

Conversation

alexcrichton
Copy link
Member

Right now ThinLTO is generating bad dwarf which is tracked by #45511, but this
is causing issues on OSX (#45768) where dsymutil is segfaulting and failing to
produce output.

Closes #45768

Right now ThinLTO is generating bad dwarf which is tracked by rust-lang#45511, but this
is causing issues on OSX (rust-lang#45768) where `dsymutil` is segfaulting and failing to
produce output.

Closes rust-lang#45768
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2017
@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Nov 12, 2017

📌 Commit f6cc9ee has been approved by Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Nov 12, 2017

⌛ Testing commit f6cc9ee with merge fb5ba4e...

bors added a commit that referenced this pull request Nov 12, 2017
…imulacrum

rustbuild: Disable ThinLTO for libtest

Right now ThinLTO is generating bad dwarf which is tracked by #45511, but this
is causing issues on OSX (#45768) where `dsymutil` is segfaulting and failing to
produce output.

Closes #45768
@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2017
@bors
Copy link
Collaborator

bors commented Nov 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing fb5ba4e to master...

@bors bors merged commit f6cc9ee into rust-lang:master Nov 12, 2017
@alexcrichton alexcrichton deleted the disable-thinlto-libtest branch December 6, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants