New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Disable ThinLTO for libtest #45908

Merged
merged 1 commit into from Nov 12, 2017

Conversation

Projects
None yet
4 participants
@alexcrichton
Member

alexcrichton commented Nov 10, 2017

Right now ThinLTO is generating bad dwarf which is tracked by #45511, but this
is causing issues on OSX (#45768) where dsymutil is segfaulting and failing to
produce output.

Closes #45768

rustbuild: Disable ThinLTO for libtest
Right now ThinLTO is generating bad dwarf which is tracked by #45511, but this
is causing issues on OSX (#45768) where `dsymutil` is segfaulting and failing to
produce output.

Closes #45768
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Nov 12, 2017

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum
Member

Mark-Simulacrum commented Nov 12, 2017

@bors r+ p=1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 12, 2017

Contributor

📌 Commit f6cc9ee has been approved by Mark-Simulacrum

Contributor

bors commented Nov 12, 2017

📌 Commit f6cc9ee has been approved by Mark-Simulacrum

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 12, 2017

Contributor

⌛️ Testing commit f6cc9ee with merge fb5ba4e...

Contributor

bors commented Nov 12, 2017

⌛️ Testing commit f6cc9ee with merge fb5ba4e...

bors added a commit that referenced this pull request Nov 12, 2017

Auto merge of #45908 - alexcrichton:disable-thinlto-libtest, r=Mark-S…
…imulacrum

rustbuild: Disable ThinLTO for libtest

Right now ThinLTO is generating bad dwarf which is tracked by #45511, but this
is causing issues on OSX (#45768) where `dsymutil` is segfaulting and failing to
produce output.

Closes #45768
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 12, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing fb5ba4e to master...

Contributor

bors commented Nov 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing fb5ba4e to master...

@bors bors merged commit f6cc9ee into rust-lang:master Nov 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:disable-thinlto-libtest branch Dec 6, 2017

@nikomatsakis nikomatsakis referenced this pull request Aug 3, 2018

Open

non-lexical lifetimes (NLL) tracking issue #43234

3 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment