New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type privacy polishing #46083

Merged
merged 5 commits into from Dec 21, 2017

Conversation

Projects
None yet
8 participants
@petrochenkov
Contributor

petrochenkov commented Nov 18, 2017

Various preparations before implementing rust-lang/rfcs#2145 containing final minor breaking changes (mostly for unstable code or code using allow(private_in_public)).
(Continuation of #42125, #44633 and #41332.)

It would be good to run crater on this.
r? @eddyb

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Nov 18, 2017

Member

@bors try

Member

eddyb commented Nov 18, 2017

@bors try

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 18, 2017

Contributor

⌛️ Trying commit 49c642c with merge 5ce31c1...

Contributor

bors commented Nov 18, 2017

⌛️ Trying commit 49c642c with merge 5ce31c1...

bors added a commit that referenced this pull request Nov 18, 2017

Auto merge of #46083 - petrochenkov:morepriv, r=<try>
Type privacy polishing

Various preparations before implementing rust-lang/rfcs#2145 containing final minor breaking changes.
(Continuation of #42125, #44633 and #41332.)

It would be good to run crater on this.
r? @eddyb
@eddyb

eddyb approved these changes Nov 18, 2017

LGTM

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb
Member

eddyb commented Nov 18, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 18, 2017

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Nov 18, 2017

☀️ Test successful - status-travis
State: approved= try=True

@petrochenkov

This comment has been minimized.

Show comment
Hide comment
@petrochenkov

petrochenkov Nov 19, 2017

Contributor

ping @aidanhs @Mark-Simulacrum
Crater run is needed.

Contributor

petrochenkov commented Nov 19, 2017

ping @aidanhs @Mark-Simulacrum
Crater run is needed.

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs

aidanhs Nov 21, 2017

Member

Crater run started

Member

aidanhs commented Nov 21, 2017

Crater run started

@carols10cents

This comment has been minimized.

Show comment
Hide comment
@carols10cents

carols10cents Nov 27, 2017

Member

Ping @aidanhs -- has crater finished?

Member

carols10cents commented Nov 27, 2017

Ping @aidanhs -- has crater finished?

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs

aidanhs Nov 27, 2017

Member

Unfortunately the build failed because the disk filled up (I'm not clear why, but it did), so I've restarted the run - it'll be done in another few days. Sorry!

Member

aidanhs commented Nov 27, 2017

Unfortunately the build failed because the disk filled up (I'm not clear why, but it did), so I've restarted the run - it'll be done in another few days. Sorry!

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs

aidanhs Nov 30, 2017

Member

Hi @petrochenkov (crater requester), @eddyb (reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-46083/index.html. 'Blacklisted' crates (spurious failures etc) can be found here. If you see any spurious failures not on the list, please make a PR against that file.

(interested observers: Crater is a tool for testing the impact of changes on the crates.io ecosystem. You can find out more at the repo if you're interested)

Member

aidanhs commented Nov 30, 2017

Hi @petrochenkov (crater requester), @eddyb (reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-46083/index.html. 'Blacklisted' crates (spurious failures etc) can be found here. If you see any spurious failures not on the list, please make a PR against that file.

(interested observers: Crater is a tool for testing the impact of changes on the crates.io ecosystem. You can find out more at the repo if you're interested)

@petrochenkov

This comment has been minimized.

Show comment
Hide comment
@petrochenkov

petrochenkov Nov 30, 2017

Contributor

Three legit regressions:

  • mioco-0.8.1 (root, private-in-public in associated types promoted to error)
  • tick-0.0.1 (root, private-in-public in associated types promoted to error)
  • razielgn.redis.fb38f9bf458c085e2d615c29488f1ec1fb09e723 (non-root, caused by mioco-0.8.1)

I'll send PRs.

Contributor

petrochenkov commented Nov 30, 2017

Three legit regressions:

  • mioco-0.8.1 (root, private-in-public in associated types promoted to error)
  • tick-0.0.1 (root, private-in-public in associated types promoted to error)
  • razielgn.redis.fb38f9bf458c085e2d615c29488f1ec1fb09e723 (non-root, caused by mioco-0.8.1)

I'll send PRs.

@petrochenkov petrochenkov referenced this pull request Nov 30, 2017

Merged

Fix build on nightly #159

@petrochenkov

This comment has been minimized.

Show comment
Hide comment
@petrochenkov

petrochenkov Nov 30, 2017

Contributor

Rebased and sent PRs to affected crates.

Contributor

petrochenkov commented Nov 30, 2017

Rebased and sent PRs to affected crates.

@shepmaster

This comment has been minimized.

Show comment
Hide comment
@shepmaster

shepmaster Dec 9, 2017

Member

Ping from triage! It's been over 7 days since we heard from reviewer @eddyb. Please assign a new reviewer @rust-lang/compiler.

Member

shepmaster commented Dec 9, 2017

Ping from triage! It's been over 7 days since we heard from reviewer @eddyb. Please assign a new reviewer @rust-lang/compiler.

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Dec 9, 2017

Member

@shepmaster Oh, sorry, IMO this is good to go, I just wanted an extra confirmation.
r? @nikomatsakis

Member

eddyb commented Dec 9, 2017

@shepmaster Oh, sorry, IMO this is good to go, I just wanted an extra confirmation.
r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Dec 9, 2017

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs

aidanhs Dec 14, 2017

Member

Ping @nikomatsakis for review! (also on IRC)

Member

aidanhs commented Dec 14, 2017

Ping @nikomatsakis for review! (also on IRC)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 15, 2017

Contributor

☔️ The latest upstream changes (presumably #46641) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Dec 15, 2017

☔️ The latest upstream changes (presumably #46641) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Dec 19, 2017

Contributor

Argh my apologies @petrochenkov

Contributor

nikomatsakis commented Dec 19, 2017

Argh my apologies @petrochenkov

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis
Contributor

nikomatsakis commented Dec 20, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 20, 2017

Contributor

📌 Commit 679165c has been approved by nikomatsakis

Contributor

bors commented Dec 20, 2017

📌 Commit 679165c has been approved by nikomatsakis

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Dec 20, 2017

Contributor

@bors r-

well, r=me, unmergeable.

Contributor

nikomatsakis commented Dec 20, 2017

@bors r-

well, r=me, unmergeable.

@petrochenkov

This comment has been minimized.

Show comment
Hide comment
@petrochenkov

petrochenkov Dec 21, 2017

Contributor

@bors r=nikomatsakis

Contributor

petrochenkov commented Dec 21, 2017

@bors r=nikomatsakis

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 21, 2017

Contributor

📌 Commit c6209a3 has been approved by nikomatsakis

Contributor

bors commented Dec 21, 2017

📌 Commit c6209a3 has been approved by nikomatsakis

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 21, 2017

Contributor

⌛️ Testing commit c6209a3 with merge a12706c...

Contributor

bors commented Dec 21, 2017

⌛️ Testing commit c6209a3 with merge a12706c...

bors added a commit that referenced this pull request Dec 21, 2017

Auto merge of #46083 - petrochenkov:morepriv, r=nikomatsakis
Type privacy polishing

Various preparations before implementing rust-lang/rfcs#2145 containing final minor breaking changes (mostly for unstable code or code using `allow(private_in_public)`).
(Continuation of #42125, #44633 and #41332.)

It would be good to run crater on this.
r? @eddyb
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 21, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing a12706c to master...

Contributor

bors commented Dec 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing a12706c to master...

@bors bors merged commit c6209a3 into rust-lang:master Dec 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment