convert most of libcore and libstd to structs, work around tzset race #4613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I want to run this on try just to be sure, but I'd love to see an end to the ignored time tests. |
This attempts to fix issue rust-lang#3327.
|
I've updated this to remove all the records I could find. Once we make a snapshot, I believe we'll be able to start removing record support from rustc. Goodbye fair |
|
Yes, I'm working on disabling records by default and adding a |
catamorphism
added a commit
that referenced
this pull request
Jan 25, 2013
convert most of libcore and libstd to structs, work around tzset race
|
And it's green! Thanks! |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good morning,
This patch converts most of the libcore and libstd records into structs. I believe all that's left is extfmt and pipes, which needs a compiler change. It also removes record support for auto-encode, with the idea of simplifying down it down for eventual merger with the deriving macro. Finally, it includes what I hope is a fix for the randomred time tests by merging all those tests into one call so there are no more races on tzset.