New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize spin_loop_hint #46174

Merged
merged 3 commits into from Nov 28, 2017

Conversation

Projects
None yet
9 participants
@stjepang
Contributor

stjepang commented Nov 21, 2017

Stabilize spin_loop_hint in release 1.23.0.
I've also renamed feature hint_core_should_pause to spin_loop_hint.

cc #41196

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 21, 2017

Collaborator

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Nov 21, 2017

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv frewsxcv assigned sfackler and unassigned frewsxcv Nov 22, 2017

@carols10cents

This comment has been minimized.

Show comment
Hide comment
@carols10cents

carols10cents Nov 27, 2017

Member

Review ping for you @sfackler !

Member

carols10cents commented Nov 27, 2017

Review ping for you @sfackler !

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Nov 27, 2017

Member

@alexcrichton Do you want to backport this to 1.23 or push it out to 1.24?

Member

sfackler commented Nov 27, 2017

@alexcrichton Do you want to backport this to 1.23 or push it out to 1.24?

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 27, 2017

Member

Nah I'm personally ok leaving it with 1.24

Member

alexcrichton commented Nov 27, 2017

Nah I'm personally ok leaving it with 1.24

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 27, 2017

Member

egad didn't mean to close...

Member

alexcrichton commented Nov 27, 2017

egad didn't mean to close...

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler
Member

sfackler commented Nov 27, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 27, 2017

Contributor

📌 Commit d5e8b61 has been approved by sfackler

Contributor

bors commented Nov 27, 2017

📌 Commit d5e8b61 has been approved by sfackler

kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017

Rollup merge of rust-lang#46174 - stjepang:stabilize-spinloophint, r=…
…sfackler

Stabilize spin_loop_hint

Stabilize `spin_loop_hint` in release `1.23.0`.
I've also renamed feature `hint_core_should_pause` to `spin_loop_hint`.

cc rust-lang#41196

bors added a commit that referenced this pull request Nov 27, 2017

Auto merge of #46312 - kennytm:rollup, r=kennytm
Rollup of 10 pull requests

- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:

bors added a commit that referenced this pull request Nov 27, 2017

Auto merge of #46312 - kennytm:rollup, r=kennytm
Rollup of 10 pull requests

- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:
@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum
Member

Mark-Simulacrum commented Nov 28, 2017

@bors rollup

@bors bors merged commit d5e8b61 into rust-lang:master Nov 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stjepang stjepang deleted the stjepang:stabilize-spinloophint branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment