New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable jemalloc on executables for ios targets #46211

Merged
merged 2 commits into from Dec 1, 2017

Conversation

Projects
None yet
8 participants
@kali
Contributor

kali commented Nov 23, 2017

This is a (temporary ?) workaround for issue #45262

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 23, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Nov 23, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents

This comment has been minimized.

Show comment
Hide comment
@carols10cents

carols10cents Nov 27, 2017

Member

Review ping for you @pnkfelix !

Member

carols10cents commented Nov 27, 2017

Review ping for you @pnkfelix !

@pnkfelix

This comment has been minimized.

Show comment
Hide comment
@pnkfelix

pnkfelix Nov 27, 2017

Member

r=me once the comment I requested above has been added.

Member

pnkfelix commented Nov 27, 2017

r=me once the comment I requested above has been added.

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Nov 30, 2017

Member

@bors r=pnkfelix

Member

sfackler commented Nov 30, 2017

@bors r=pnkfelix

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 30, 2017

Contributor

📌 Commit 3b18e29 has been approved by pnkfelix

Contributor

bors commented Nov 30, 2017

📌 Commit 3b18e29 has been approved by pnkfelix

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Nov 30, 2017

Member

@alexcrichton thoughts on backporting to beta? Seems like it'd be nice to fix iOS bins earlier rather than later and it should be low risk.

Member

sfackler commented Nov 30, 2017

@alexcrichton thoughts on backporting to beta? Seems like it'd be nice to fix iOS bins earlier rather than later and it should be low risk.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 30, 2017

Member

Sure!

Member

alexcrichton commented Nov 30, 2017

Sure!

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 1, 2017

Contributor

⌛️ Testing commit 3b18e29 with merge 315fbf7...

Contributor

bors commented Dec 1, 2017

⌛️ Testing commit 3b18e29 with merge 315fbf7...

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46211 - snipsco:master, r=pnkfelix
disable jemalloc on executables for ios targets

This is a (temporary ?) workaround for issue #45262
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 1, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 315fbf7 to master...

Contributor

bors commented Dec 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 315fbf7 to master...

@bors bors merged commit 3b18e29 into rust-lang:master Dec 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

bors added a commit that referenced this pull request Dec 23, 2017

Auto merge of #46912 - pnkfelix:backport-46211-to-beta, r=kennytm
Backport to beta: disable jemalloc on executables for ios targets

Back port of #46211
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jan 10, 2018

Member

Looks like we forgot to backport to 1.23.0 (sorry about that!) so removing the beta tags.

Member

alexcrichton commented Jan 10, 2018

Looks like we forgot to backport to 1.23.0 (sorry about that!) so removing the beta tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment