New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Formatter::flags method, fix #46237 #46284

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
6 participants
@SimonSapin
Contributor

SimonSapin commented Nov 26, 2017

This fixes #46237.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 26, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Nov 26, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Nov 26, 2017

Member

@alexcrichton this isn't going to mess with any of the fmt impl's internals, right?

Member

sfackler commented Nov 26, 2017

@alexcrichton this isn't going to mess with any of the fmt impl's internals, right?

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin

SimonSapin Nov 26, 2017

Contributor

git grep '\.flags()' (excluding submodules) shows zero matches. I’m counting on CI to tell us if something else needs to be adjusted.

Contributor

SimonSapin commented Nov 26, 2017

git grep '\.flags()' (excluding submodules) shows zero matches. I’m counting on CI to tell us if something else needs to be adjusted.

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Nov 26, 2017

Member

Ah great!

@bors r+

Member

sfackler commented Nov 26, 2017

Ah great!

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 26, 2017

Contributor

📌 Commit 5e11c8f has been approved by sfackler

Contributor

bors commented Nov 26, 2017

📌 Commit 5e11c8f has been approved by sfackler

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler
Member

sfackler commented Nov 26, 2017

@dtolnay

LGTM

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 27, 2017

Contributor

⌛️ Testing commit 5e11c8f with merge 8270faf...

Contributor

bors commented Nov 27, 2017

⌛️ Testing commit 5e11c8f with merge 8270faf...

bors added a commit that referenced this pull request Nov 27, 2017

Auto merge of #46284 - SimonSapin:deprecate-formatter-flags, r=sfackler
Deprecate the Formatter::flags method, fix #46237

This fixes #46237.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 27, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 8270faf to master...

Contributor

bors commented Nov 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 8270faf to master...

@bors bors merged commit 5e11c8f into rust-lang:master Nov 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the SimonSapin:deprecate-formatter-flags branch Nov 27, 2017

@bluss bluss added the relnotes label Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment