New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl From<bool> for AtomicBool #46293

Merged
merged 2 commits into from Nov 29, 2017

Conversation

Projects
None yet
9 participants
@ollie27
Contributor

ollie27 commented Nov 27, 2017

This seems like an obvious omission from #45610. I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to 1.24.0.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 27, 2017

Collaborator

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Nov 27, 2017

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 27, 2017

Member

Marked as beta nominated.

cc @rust-lang/libs -- what do you think about backporting this to beta?

Member

Mark-Simulacrum commented Nov 27, 2017

Marked as beta nominated.

cc @rust-lang/libs -- what do you think about backporting this to beta?

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Nov 27, 2017

Member

I don't really see any reason to backport this.

Member

sfackler commented Nov 27, 2017

I don't really see any reason to backport this.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 27, 2017

Member

Agreed that feature-wise this seems fine but I probably wouldn't do the backport

Member

alexcrichton commented Nov 27, 2017

Agreed that feature-wise this seems fine but I probably wouldn't do the backport

@TimNN TimNN assigned BurntSushi and unassigned TimNN Nov 27, 2017

@ollie27

This comment has been minimized.

Show comment
Hide comment
@ollie27

ollie27 Nov 27, 2017

Contributor

Right, I've changed it to 1.24.0.

Contributor

ollie27 commented Nov 27, 2017

Right, I've changed it to 1.24.0.

@kennytm kennytm removed the beta-nominated label Nov 27, 2017

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Nov 28, 2017

Member

LGTM. @bors r+

Member

BurntSushi commented Nov 28, 2017

LGTM. @bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 28, 2017

Contributor

📌 Commit 71d766b has been approved by BurntSushi

Contributor

bors commented Nov 28, 2017

📌 Commit 71d766b has been approved by BurntSushi

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum
Member

Mark-Simulacrum commented Nov 28, 2017

@bors rollup

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 29, 2017

Contributor

⌛️ Testing commit 71d766b with merge 736976d...

Contributor

bors commented Nov 29, 2017

⌛️ Testing commit 71d766b with merge 736976d...

bors added a commit that referenced this pull request Nov 29, 2017

Auto merge of #46293 - ollie27:atomic_bool_from, r=BurntSushi
impl From<bool> for AtomicBool

This seems like an obvious omission from #45610. ~~I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to `1.24.0`.~~
@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 29, 2017

Member

@bors treeclosed=1

Something's wrong with the macOS CI, investigating.

Member

kennytm commented Nov 29, 2017

@bors treeclosed=1

Something's wrong with the macOS CI, investigating.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 29, 2017

Contributor

💔 Test failed - status-travis

Contributor

bors commented Nov 29, 2017

💔 Test failed - status-travis

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm
Member

kennytm commented Nov 29, 2017

kennytm added a commit to kennytm/rust that referenced this pull request Nov 29, 2017

Rollup merge of rust-lang#46293 - ollie27:atomic_bool_from, r=BurntSushi
impl From<bool> for AtomicBool

This seems like an obvious omission from rust-lang#45610. ~~I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to `1.24.0`.~~

bors added a commit that referenced this pull request Nov 29, 2017

Auto merge of #46362 - kennytm:rollup, r=kennytm
Rollup of 10 pull requests

- Successful merges: #45969, #46077, #46219, #46287, #46293, #46322, #46323, #46330, #46354, #46356
- Failed merges:

@bors bors merged commit 71d766b into rust-lang:master Nov 29, 2017

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ollie27 ollie27 deleted the ollie27:atomic_bool_from branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment