New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stablize RefCell::{replace, swap} #46517

Merged
merged 3 commits into from Dec 20, 2017

Conversation

Projects
None yet
10 participants
@notriddle
Contributor

notriddle commented Dec 5, 2017

RefCell::replace_with is not stablized in this PR, since it wasn't part of the RFC.

CC #43570

Stablize RefCell::{replace, swap}
RefCell::replace_with is not stablized in this PR, since it wasn't part of the RFC.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 5, 2017

Collaborator

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Dec 5, 2017

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs
Member

aidanhs commented Dec 5, 2017

@rust-highfive rust-highfive assigned BurntSushi and unassigned aidanhs Dec 5, 2017

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Dec 5, 2017

Member

@rfcbot fcp merge

Member

BurntSushi commented Dec 5, 2017

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Dec 5, 2017

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Dec 5, 2017

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Dec 5, 2017

Member
[00:03:57] tidy error: /checkout/src/libcore/cell.rs:619: mismatches to previous in: ["stability level", "since", "tracking issue"]
[00:03:57] tidy error: /checkout/src/libcore/cell.rs:646: mismatches to previous in: ["stability level", "since", "tracking issue"]
Member

Mark-Simulacrum commented Dec 5, 2017

[00:03:57] tidy error: /checkout/src/libcore/cell.rs:619: mismatches to previous in: ["stability level", "since", "tracking issue"]
[00:03:57] tidy error: /checkout/src/libcore/cell.rs:646: mismatches to previous in: ["stability level", "since", "tracking issue"]
Move replace_with to its own feature flag
I'm not allowed to have the same feature flag associated with multiple stability levels.
@dtolnay

I think when we stabilize part of a library feature, we pick a new name for the stabilized part and keep the old feature name for the remaining unstable part. This minimizes nightly breakage for code that is currently calling replace_with.

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Dec 13, 2017

Member

Ping @aturon for ticky boxes here!

Member

kennytm commented Dec 13, 2017

Ping @aturon for ticky boxes here!

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@notriddle

This comment has been minimized.

Show comment
Hide comment
@notriddle

notriddle Dec 19, 2017

Contributor

@dtolnay I fixed the feature flags to work the way you asked.

Contributor

notriddle commented Dec 19, 2017

@dtolnay I fixed the feature flags to work the way you asked.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 19, 2017

Member

@bors: r=BurntSushi

Member

alexcrichton commented Dec 19, 2017

@bors: r=BurntSushi

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 19, 2017

Contributor

📌 Commit 19775f7 has been approved by BurntSushi

Contributor

bors commented Dec 19, 2017

📌 Commit 19775f7 has been approved by BurntSushi

kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017

Rollup merge of #46517 - notriddle:patch-2, r=BurntSushi
Stablize RefCell::{replace, swap}

RefCell::replace_with is not stablized in this PR, since it wasn't part of the RFC.

CC #43570

bors added a commit that referenced this pull request Dec 20, 2017

Auto merge of #46874 - kennytm:rollup, r=kennytm
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 20, 2017

Contributor

⌛️ Testing commit 19775f7 with merge 81622c6...

Contributor

bors commented Dec 20, 2017

⌛️ Testing commit 19775f7 with merge 81622c6...

@bors bors merged commit 19775f7 into rust-lang:master Dec 20, 2017

1 of 2 checks passed

homu Testing commit 19775f73a39c73298c3507fe861bec8dae4e4c1f with merge 81622c6b02536bdcf56145beb317da0d336703c1...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notriddle notriddle deleted the notriddle:patch-2 branch Dec 20, 2017

@ErichDonGubler ErichDonGubler referenced this pull request Dec 29, 2017

Open

Remove nightly dependencies #15

3 of 7 tasks complete

@alexcrichton alexcrichton referenced this pull request Mar 1, 2018

Open

Tracking issue for RefCell::{replace, swap} #43570

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment