New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hash impl for SystemTime and Instant #46828

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
7 participants
@vi
Contributor

vi commented Dec 18, 2017

Closes #46670.

Not sure how to actually test non-Linux platforms.
rustc --target=i686-pc-windows-gnu --crate-name std --crate-type rlib src/libstd/lib.rs -o q.rlib works a bit, but for Redox I'm not sure what to do.

r? @dtolnay

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 18, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Dec 18, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dtolnay

Thanks! This looks good to me.

@dtolnay

This comment has been minimized.

Show comment
Hide comment
@dtolnay

dtolnay Dec 19, 2017

Member

Regarding non-Linux platforms, I don't know either but we can see what CI says and go from there.

@bors try

Member

dtolnay commented Dec 19, 2017

Regarding non-Linux platforms, I don't know either but we can see what CI says and go from there.

@bors try

@dtolnay dtolnay added the T-libs label Dec 19, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 19, 2017

Contributor

⌛️ Trying commit 1d5ead4 with merge 5bda5ad...

Contributor

bors commented Dec 19, 2017

⌛️ Trying commit 1d5ead4 with merge 5bda5ad...

bors added a commit that referenced this pull request Dec 19, 2017

Auto merge of #46828 - vi:hash_for_systemtime_instant, r=<try>
Add Hash impl for SystemTime and Instant

Closes #46670.

Not sure how to actually test non-Linux platforms.
`rustc --target=i686-pc-windows-gnu --crate-name std --crate-type rlib src/libstd/lib.rs -o q.rlib` works a bit, but for Redox I'm not sure what to do.

r? @dtolnay
@dtolnay

This comment has been minimized.

Show comment
Hide comment
@dtolnay

dtolnay Dec 19, 2017

Member

Since this is adding some new stable trait impls, let's run it by the rest of @rust-lang/libs as well.

impl Hash for std::time::Instant { /* ... */ }
impl Hash for std::time::SystemTime { /* ... */ }

@rfcbot fcp merge

Member

dtolnay commented Dec 19, 2017

Since this is adding some new stable trait impls, let's run it by the rest of @rust-lang/libs as well.

impl Hash for std::time::Instant { /* ... */ }
impl Hash for std::time::SystemTime { /* ... */ }

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Dec 19, 2017

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Dec 19, 2017

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 19, 2017

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Dec 19, 2017

☀️ Test successful - status-travis
State: approved= try=True

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 19, 2017

Member

@bors: r=dtolnay

Member

alexcrichton commented Dec 19, 2017

@bors: r=dtolnay

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 19, 2017

Contributor

📌 Commit 1d5ead4 has been approved by dtolnay

Contributor

bors commented Dec 19, 2017

📌 Commit 1d5ead4 has been approved by dtolnay

kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017

Rollup merge of rust-lang#46828 - vi:hash_for_systemtime_instant, r=d…
…tolnay

Add Hash impl for SystemTime and Instant

Closes rust-lang#46670.

Not sure how to actually test non-Linux platforms.
`rustc --target=i686-pc-windows-gnu --crate-name std --crate-type rlib src/libstd/lib.rs -o q.rlib` works a bit, but for Redox I'm not sure what to do.

r? @dtolnay

bors added a commit that referenced this pull request Dec 20, 2017

Auto merge of #46874 - kennytm:rollup, r=kennytm
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:

@bors bors merged commit 1d5ead4 into rust-lang:master Dec 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment