New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject superfluous `::` in IPv6 addresses #46671

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
9 participants
@varkor
Contributor

varkor commented Dec 11, 2017

Fixes #46263.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 11, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Dec 11, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv added the T-libs label Dec 12, 2017

@KodrAus

This comment has been minimized.

Show comment
Hide comment
@KodrAus

KodrAus Dec 12, 2017

Thanks @varkor!

This looks good to me. With this change we'll start rejecting previously accepted (but technically invalid) Ipv6Addrs where the address specifies 0 groups of 0s.

@rfcbot fcp merge

KodrAus commented Dec 12, 2017

Thanks @varkor!

This looks good to me. With this change we'll start rejecting previously accepted (but technically invalid) Ipv6Addrs where the address specifies 0 groups of 0s.

@rfcbot fcp merge

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Dec 12, 2017

Member

@KodrAus Only members of the team can awake rfcbot 😄

cc @rust-lang/libs

Member

kennytm commented Dec 12, 2017

@KodrAus Only members of the team can awake rfcbot 😄

cc @rust-lang/libs

@sfackler

This comment has been minimized.

Show comment
Hide comment
@sfackler

sfackler Dec 12, 2017

Member

@rfcbot fcp merge

Member

sfackler commented Dec 12, 2017

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Dec 12, 2017

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Dec 12, 2017

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 19, 2017

Member

@bors: r=KodrAus

Member

alexcrichton commented Dec 19, 2017

@bors: r=KodrAus

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 19, 2017

Contributor

📌 Commit bd1cf04 has been approved by KodrAus

Contributor

bors commented Dec 19, 2017

📌 Commit bd1cf04 has been approved by KodrAus

kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017

Rollup merge of rust-lang#46671 - varkor:contrib-2, r=KodrAus
Reject superfluous `::` in IPv6 addresses

Fixes rust-lang#46263.

bors added a commit that referenced this pull request Dec 20, 2017

Auto merge of #46874 - kennytm:rollup, r=kennytm
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:

@bors bors merged commit bd1cf04 into rust-lang:master Dec 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment