incr.comp.: Add -C incremental in addition to -Z incremental
#46751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwoerister
force-pushed
the
c-incremental
branch
from
ae8b0d0
to
e6ae17c
Compare
kennytm
added
S-waiting-on-review
bjorn3
requested changes
Dec 16, 2017
src/librustc/session/config.rs
Outdated
| if cg.lto && debugging_opts.incremental.is_some() { | ||
| let incremental = match (&debugging_opts.incremental, &cg.incremental) { | ||
| (&Some(ref path1), &Some(ref path2)) => { | ||
| if path1 == path2 { |
There was a problem hiding this comment.
Shouldnt this be a !=, currently it errors when there is no conflict
There was a problem hiding this comment.
Good catch! Thanks, @bjorn3.
|
r=me with a typo fix |
michaelwoerister
force-pushed
the
c-incremental
branch
from
e6ae17c
to
796264b
Compare
|
@bors: r+ |
|
📌 Commit 796264b has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 796264b with merge b918f0484127ce7076cc9810e85c9e9f856fbf12... |
|
Might travis be stuck somewhere? The build for i686-gnu hasn't started yet whilst all others are done but according to travis status there is no backlog for linux |
|
💔 Test failed - status-travis |
|
@bors: retry
|
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 20, 2017
…lexcrichton incr.comp.: Add `-C incremental` in addition to `-Z incremental` This PR adds a stable commandline option for invoking incremental compilation. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stable commandline option for invoking incremental compilation.
r? @alexcrichton