Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division-by-zero ICE in -Z perf-stats #46728

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Conversation

varkor
Copy link
Member

@varkor varkor commented Dec 14, 2017

An invalid average now simply prints “N/A”. Fixes #46725.

An invalid average now simply prints “N/A”. Fixes rust-lang#46725.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Dec 14, 2017

r? @michaelwoerister

@michaelwoerister
Copy link
Member

Thank you, @varkor!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 14, 2017

📌 Commit 7b5981a has been approved by michaelwoerister

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 14, 2017
@kennytm
Copy link
Member

kennytm commented Dec 14, 2017

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 15, 2017
Fix division-by-zero ICE in -Z perf-stats

An invalid average now simply prints “N/A”. Fixes rust-lang#46725.
bors added a commit that referenced this pull request Dec 15, 2017
Rollup of 7 pull requests

- Successful merges: #46601, #46652, #46690, #46705, #46710, #46728, #46737
- Failed merges:
@bors bors merged commit 7b5981a into rust-lang:master Dec 15, 2017
@varkor varkor deleted the contrib-4 branch December 15, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants