New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code for unused const- and inline-fns if -Clink-dead-code is specified. #46916

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
7 participants
@michaelwoerister
Contributor

michaelwoerister commented Dec 21, 2017

Fixes #46467.

r? @alexcrichton

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 21, 2017

Member

@bors: r+

Nice!

Member

alexcrichton commented Dec 21, 2017

@bors: r+

Nice!

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 21, 2017

Contributor

📌 Commit f284ebb has been approved by alexcrichton

Contributor

bors commented Dec 21, 2017

📌 Commit f284ebb has been approved by alexcrichton

kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017

Rollup merge of rust-lang#46916 - michaelwoerister:generate-dead-code…
…-plz, r=alexcrichton

Generate code for unused const- and inline-fns if -Clink-dead-code is specified.

Fixes rust-lang#46467.

r? @alexcrichton

bors added a commit that referenced this pull request Dec 21, 2017

Auto merge of #46922 - kennytm:rollup, r=kennytm
Rollup of 15 pull requests

- Successful merges: #46636, #46780, #46784, #46809, #46814, #46820, #46839, #46847, #46858, #46878, #46884, #46890, #46898, #46916, #46918
- Failed merges:
@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Dec 21, 2017

Member

@bors r-

The new test failed in the rollup.

Member

kennytm commented Dec 21, 2017

@bors r-

The new test failed in the rollup.

Show outdated Hide outdated src/test/codegen/link-dead-code.rs Outdated
@pnkfelix

This comment has been minimized.

Show comment
Hide comment
@pnkfelix

pnkfelix Dec 29, 2017

Member

@michaelwoerister are you going to be able to address the problem pointed out by kennytm?

Times getting very tight to backport this into beta...

Member

pnkfelix commented Dec 29, 2017

@michaelwoerister are you going to be able to address the problem pointed out by kennytm?

Times getting very tight to backport this into beta...

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister

michaelwoerister Jan 4, 2018

Contributor

Whoops, sorry, didn't see this because of PTO.

Contributor

michaelwoerister commented Jan 4, 2018

Whoops, sorry, didn't see this because of PTO.

@kennytm

kennytm approved these changes Jan 4, 2018

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister

michaelwoerister Jan 4, 2018

Contributor

@bors r=alexcrichton

Contributor

michaelwoerister commented Jan 4, 2018

@bors r=alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

📌 Commit 238ed47 has been approved by alexcrichton

Contributor

bors commented Jan 4, 2018

📌 Commit 238ed47 has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

⌛️ Testing commit 238ed47 with merge 8e7a609...

Contributor

bors commented Jan 4, 2018

⌛️ Testing commit 238ed47 with merge 8e7a609...

bors added a commit that referenced this pull request Jan 4, 2018

Auto merge of #46916 - michaelwoerister:generate-dead-code-plz, r=ale…
…xcrichton

Generate code for unused const- and inline-fns if -Clink-dead-code is specified.

Fixes #46467.

r? @alexcrichton
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8e7a609 to master...

Contributor

bors commented Jan 4, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8e7a609 to master...

@bors bors merged commit 238ed47 into rust-lang:master Jan 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@nagisa nagisa added the T-compiler label Jan 7, 2018

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jan 10, 2018

Member

Accepting for backport as it fixes a regression #46467

Member

alexcrichton commented Jan 10, 2018

Accepting for backport as it fixes a regression #46467

@MaloJaffre MaloJaffre referenced this pull request Jan 10, 2018

Merged

[beta] Backports #47327

bors added a commit that referenced this pull request Jan 10, 2018

Auto merge of #47327 - MaloJaffre:beta-backport, r=Mark-Simulacrum
[beta] Backports

Cherry-picked (cleanly) into beta:
- #46916
- #47161
- #47208
- #47269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment