New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay panic from incoherent drop implementation #47104

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
5 participants
@matthewjasper
Contributor

matthewjasper commented Jan 1, 2018

Closes #41974

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jan 1, 2018

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Jan 1, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Jan 2, 2018

Contributor

@bors r+ rollup

Contributor

estebank commented Jan 2, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 2, 2018

Contributor

📌 Commit 31a4cba has been approved by estebank

Contributor

bors commented Jan 2, 2018

📌 Commit 31a4cba has been approved by estebank

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 2, 2018

Contributor

⌛️ Testing commit 31a4cba with merge 73b70d1...

Contributor

bors commented Jan 2, 2018

⌛️ Testing commit 31a4cba with merge 73b70d1...

bors added a commit that referenced this pull request Jan 2, 2018

Auto merge of #47104 - matthewjasper:dont-panic-on-generic-drop, r=es…
…tebank

Delay panic from incoherent drop implementation

Closes #41974
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 2, 2018

Contributor

💔 Test failed - status-travis

Contributor

bors commented Jan 2, 2018

💔 Test failed - status-travis

@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Jan 2, 2018

Contributor

@bors retry

Contributor

estebank commented Jan 2, 2018

@bors retry

kennytm added a commit to kennytm/rust that referenced this pull request Jan 3, 2018

Rollup merge of rust-lang#47104 - matthewjasper:dont-panic-on-generic…
…-drop, r=estebank

Delay panic from incoherent drop implementation

Closes rust-lang#41974

@kennytm kennytm referenced this pull request Jan 3, 2018

Merged

Rollup of 9 pull requests #47151

bors added a commit that referenced this pull request Jan 3, 2018

Auto merge of #47151 - kennytm:rollup, r=kennytm
Rollup of 9 pull requests

- Successful merges: #47104, #47107, #47113, #47117, #47118, #47121, #47125, #47134, #47145
- Failed merges:
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 3, 2018

Contributor

☔️ The latest upstream changes (presumably #47151) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Jan 3, 2018

☔️ The latest upstream changes (presumably #47151) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 31a4cba into rust-lang:master Jan 3, 2018

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matthewjasper matthewjasper deleted the matthewjasper:dont-panic-on-generic-drop branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment