Skip to content

rustc_trans: ignore trailing padding larger than 8 bytes. #47439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2018
Merged

rustc_trans: ignore trailing padding larger than 8 bytes. #47439

merged 1 commit into from
Jan 26, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jan 15, 2018

Fixes #45662 by ignoring a missing second register component, as it could be entirely padding.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member Author

eddyb commented Jan 15, 2018

r? @nagisa

@eddyb eddyb mentioned this pull request Jan 15, 2018
Closed
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2018
@nagisa
Copy link
Member

nagisa commented Jan 15, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2018

📌 Commit fc89a22 has been approved by nagisa

@eddyb
Copy link
Member Author

eddyb commented Jan 16, 2018

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Jan 16, 2018

📌 Commit 9b95e91 has been approved by nagisa

@shepmaster shepmaster added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 25, 2018
@alexcrichton
Rollup merge of rust-lang#47439 - eddyb:issue-45662, r=nagisa
6eb1430 
rustc_trans: ignore trailing padding larger than 8 bytes.

Fixes rust-lang#45662 by ignoring a missing second register component, as it could be entirely padding.
@alexcrichton alexcrichton mentioned this pull request Jan 25, 2018
Merged
bors added a commit that referenced this pull request Jan 26, 2018
@bors
Auto merge of #47748 - alexcrichton:rollup, r=alexcrichton
bacb5c5 
Rollup of 19 pull requests

- Successful merges: #47415, #47437, #47439, #47453, #47460, #47502, #47529, #47600, #47607, #47618, #47626, #47656, #47668, #47696, #47701, #47705, #47710, #47711, #47719
- Failed merges: #47455, #47521
@bors bors merged commit 9b95e91 into rust-lang:master Jan 26, 2018
@eddyb eddyb deleted the issue-45662 branch January 26, 2018 22:09
@KiChjang KiChjang mentioned this pull request Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eddyb @rust-highfive @nagisa @bors @kennytm @shepmaster @michaelwoerister