Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitelist x86 fxsr feature #47514

Merged
merged 1 commit into from Jan 17, 2018
Merged

whitelist x86 fxsr feature #47514

merged 1 commit into from Jan 17, 2018

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Jan 17, 2018

#47223 properly checks that only white-listed features are allowed in combination with target_feature, but the fxsr feature used by stdsimd was not white-listed.

r? @alexcrichton

@hanna-kruppe
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 17, 2018

📌 Commit 86d6301 has been approved by rkruppe

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 17, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 17, 2018
@kennytm
Rollup merge of rust-lang#47514 - gnzlbg:whitelist_x86_fxsr, r=rkruppe
5fade39 
whitelist x86 fxsr feature

rust-lang#47223 properly checks that only white-listed features are allowed in combination with `target_feature`, but the `fxsr` feature used by `stdsimd` was not white-listed.

r? @alexcrichton
@kennytm kennytm mentioned this pull request Jan 17, 2018
Merged
bors added a commit that referenced this pull request Jan 17, 2018
@bors
Auto merge of #47522 - kennytm:rollup, r=kennytm
0f9c784 
Rollup of 21 pull requests

- Successful merges: #47302, #47333, #47387, #47404, #47407, #47426, #47427, #47436, #47444, #47456, #47458, #47467, #47479, #47481, #47483, #47487, #47497, #47498, #47505, #47509, #47514
- Failed merges:
@bors bors merged commit 86d6301 into rust-lang:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnzlbg @hanna-kruppe @bors @alexcrichton @kennytm