Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automaticaly calculate beta prerelease numbers #47582

Merged
merged 1 commit into from Jan 22, 2018
Merged

Automaticaly calculate beta prerelease numbers #47582

merged 1 commit into from Jan 22, 2018

Conversation

alexcrichton
Copy link
Member

This is a forward-port of:

from the beta branch which is used to automatically calculate the beta number
based on the number of merges to the beta branch so far.

@alexcrichton
Copy link
Member Author

r? @kennytm

@alexcrichton alexcrichton reopened this Jan 19, 2018
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2018
kennytm
kennytm reviewed Jan 19, 2018
View reviewed changes
src/bootstrap/lib.rs Outdated
);
let n = count.trim().parse().unwrap();
self.prerelease_version.set(Some(n));
return n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: This could simply be n...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@alexcrichton
Automaticaly calculate beta prerelease numbers
06913a5 
This is a forward-port of:

* 9426dda
* cbfb985

from the beta branch which is used to automatically calculate the beta number
based on the number of merges to the beta branch so far.
@kennytm
Copy link
Member

kennytm commented Jan 19, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2018

📌 Commit 06913a5 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2018
@frewsxcv
Copy link
Member

@bors rollup

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 21, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 21, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47582 - alexcrichton:auto-beta, r=kennytm
35221d8 
Automaticaly calculate beta prerelease numbers

This is a forward-port of:

* 9426dda
* cbfb985

from the beta branch which is used to automatically calculate the beta number
based on the number of merges to the beta branch so far.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 21, 2018
Merged
bors added a commit that referenced this pull request Jan 21, 2018
@bors
Auto merge of #47644 - GuillaumeGomez:rollup, r=GuillaumeGomez
ff2a7c8 
Rollup of 9 pull requests

- Successful merges: #47247, #47334, #47512, #47582, #47595, #47625, #47632, #47633, #47637
- Failed merges:
@bors bors merged commit 06913a5 into rust-lang:master Jan 22, 2018
@alexcrichton alexcrichton deleted the auto-beta branch January 23, 2018 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexcrichton @kennytm @bors @frewsxcv