Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the IGNORED_ATTR_NAMES thread local #47635

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Remove the IGNORED_ATTR_NAMES thread local #47635

merged 1 commit into from
Jan 23, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 21, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2018
@michaelwoerister
Copy link
Member

Can you provide some reasoning why you want to change this?

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 22, 2018

It's part of the parallelization work. Global state should be avoided in general too.

@michaelwoerister
Copy link
Member

@bors r+ rollup

OK, but in general I would prefer if we waited with refactorings like these until we have decided how to actually approach parallelization.

@bors
Copy link
Contributor

bors commented Jan 22, 2018

📌 Commit 643e71e has been approved by michaelwoerister

@kennytm kennytm mentioned this pull request Jan 23, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 23, 2018
@kennytm
Rollup merge of rust-lang#47635 - Zoxc:remove-attr, r=michaelwoerister
9d26a25 
Remove the IGNORED_ATTR_NAMES thread local
bors added a commit that referenced this pull request Jan 23, 2018
@bors
Auto merge of #47678 - kennytm:rollup, r=kennytm
4e3901d 
Rollup of 14 pull requests

- Successful merges: #47423, #47425, #47440, #47541, #47549, #47554, #47558, #47610, #47635, #47655, #47661, #47662, #47667, #47672
- Failed merges:
@bors bors merged commit 643e71e into rust-lang:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Zoxc @rust-highfive @michaelwoerister @bors @kennytm