Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove section about compiler-rt in COPYRIGHT. #48305

Closed
wants to merge 1 commit into from

Conversation

frewsxcv
Copy link
Member

src/compiler-rt was moved out of tree in #42899.

`src/compiler-rt` was moved out of tree in rust-lang#42899.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2018
@cuviper
Copy link
Member

cuviper commented Feb 17, 2018

But we do still ship compiler-rt indirectly -- now in src/libcompiler_builtins/compiler-rt/

@frewsxcv
Copy link
Member Author

Does the COPYRIGHT file in this particular repo need to list all copyright information of all out-of-tree dependencies? I actually don't know the answer

@cuviper
Copy link
Member

cuviper commented Feb 17, 2018

I'm not sure either, but my point is that the distribution status didn't really change. It was already an out-of-tree submodule before, and now it's a submodule of a submodule instead. Either way, it's still a part of the build, and we still include it in the rustc-src tarballs.

@kennytm kennytm added the T-core Relevant to the core team, which will review and decide on the PR/issue. label Feb 21, 2018
@alexcrichton
Copy link
Member

Ah yeah we still ship compiler-rt so I think we probably need to keep to include this notice. In theory we want difference license files based on whether it's a git checkout or a tarball, but that's a lot of work so sticking to the superset, the tarball, is probably best for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-core Relevant to the core team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants