Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark doc examples w/ extern blocks as ignore. #48325

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Mark doc examples w/ extern blocks as ignore. #48325

merged 1 commit into from
Feb 22, 2018

Conversation

frewsxcv
Copy link
Member

Fixes #48218.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2018
@frewsxcv
Copy link
Member Author

r? @steveklabnik

@kennytm
Copy link
Member

kennytm commented Feb 18, 2018

Could we hide the “run” button, or insert a #![crate_type="lib"] when sending to playground when a code block is marked as ```no_run, instead of ignoring the tests?

@steveklabnik
Copy link
Member

Could we hide the “run” button, or insert a #![crate_type="lib"] when sending to playground when a code block is marked as ```no_run, instead of ignoring the tests?

This sounds like a separate request; we do hide the run button for ignore already... maybe open an issue?

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks!

@bors
Copy link
Contributor

bors commented Feb 20, 2018

📌 Commit 872c782 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48325 - frewsxcv:frewxcv-ignore, r=stevekla…
27c6ff5 
…bnik

Mark doc examples w/ `extern` blocks as `ignore`.

Fixes rust-lang#48218.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 21, 2018
Merged
bors added a commit that referenced this pull request Feb 22, 2018
@bors
Auto merge of #48399 - GuillaumeGomez:rollup, r=GuillaumeGomez
b1f8e6f 
Rollup of 12 pull requests

- Successful merges: #47379, #47833, #48106, #48198, #48314, #48325, #48335, #48352, #48354, #48360, #48382, #48397
- Failed merges:
@bors bors merged commit 872c782 into rust-lang:master Feb 22, 2018
@frewsxcv frewsxcv deleted the frewxcv-ignore branch May 13, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @kennytm @steveklabnik @bors