Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #48816 don't print help on indirect compiler ICE #48993

Merged
merged 1 commit into from Mar 14, 2018
Merged

fix #48816 don't print help on indirect compiler ICE #48993

merged 1 commit into from Mar 14, 2018

Conversation

alexheretic
Copy link
Member

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2018
@michaelwoerister
Copy link
Member

Thanks, @alexheretic! Great debugging!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2018

📌 Commit 63f654a has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2018
@gilescope gilescope mentioned this pull request Mar 14, 2018
Closed
@kennytm kennytm mentioned this pull request Mar 14, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 14, 2018
@kennytm
Rollup merge of rust-lang#48993 - alexheretic:fix-48816, r=michaelwoe…
508ffa3 
…rister

fix rust-lang#48816 don't print help on indirect compiler ICE

rust-lang#48816 (comment)
bors added a commit that referenced this pull request Mar 14, 2018
@bors
Auto merge of #49008 - kennytm:rollup, r=kennytm
521d91c 
Rollup of 12 pull requests

- Successful merges: #48765, #48831, #48840, #48964, #48970, #48971, #48981, #48988, #48991, #48966, #48993, #48874
- Failed merges:
@bors bors merged commit 63f654a into rust-lang:master Mar 14, 2018
@alexheretic alexheretic deleted the fix-48816 branch March 14, 2018 23:49
@alexheretic alexheretic mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexheretic @rust-highfive @michaelwoerister @bors @nikomatsakis