Skip to content

Fix automatic urls with backticks #49189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fix automatic urls with backticks #49189

merged 1 commit into from
Mar 22, 2018

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2018
QuietMisdreavus
QuietMisdreavus approved these changes Mar 20, 2018
View reviewed changes
src/librustdoc/clean/mod.rs
continue;
}
let (def, fragment) = {
let link = ori_link.replace("`", "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some part of me wants this to be a trim_matches instead of a replace, but in practice it won't matter.

@QuietMisdreavus
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 20, 2018

📌 Commit bac6484 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@kennytm kennytm mentioned this pull request Mar 21, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018
@kennytm
Rollup merge of rust-lang#49189 - GuillaumeGomez:fix-implied-shortcut…
c8a3507 
…-links, r=QuietMisdreavus

Fix automatic urls with backticks

Fixes rust-lang#49164.

r? @QuietMisdreavus
@kennytm kennytm mentioned this pull request Mar 22, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
@kennytm
Rollup merge of rust-lang#49189 - GuillaumeGomez:fix-implied-shortcut…
d7eda77 
…-links, r=QuietMisdreavus

Fix automatic urls with backticks

Fixes rust-lang#49164.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Mar 22, 2018
@bors
Auto merge of #49264 - kennytm:rollup, r=kennytm
5092c6b 
Rollup of 23 pull requests

- Successful merges: #48374, #48596, #48759, #48939, #49029, #49069, #49093, #49109, #49117, #49140, #49158, #49188, #49189, #49209, #49211, #49216, #49225, #49231, #49234, #49242, #49244, #49105, #49038
- Failed merges:
@alexcrichton alexcrichton merged commit bac6484 into rust-lang:master Mar 22, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-implied-shortcut-links branch March 23, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @QuietMisdreavus @bors @alexcrichton @rust-highfive