Skip to content

src/libcore/ptr.rs: Fix documentation for size of Option<NonNull<T>> #49473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

src/libcore/ptr.rs: Fix documentation for size of Option<NonNull<T>> #49473

merged 1 commit into from
Mar 30, 2018

Conversation

joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Mar 29, 2018 •
edited
Loading

Seems more useful to say that it has the same size as *mut T.

@joshtriplett
src/libcore/ptr.rs: Fix documentation for size of Option<NonNull<T>>
39fe29b 
Seems more useful to say that it has the same size as `*mut T`.
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2018
@steveklabnik
Copy link
Contributor

Thanks! To be clear, the size is *mut T, not T. It's correct in the code, but not correct in the PR description 👍

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 29, 2018

📌 Commit 39fe29b has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2018
@joshtriplett
Copy link
Member Author

@steveklabnik I fixed it in the commit message, just not in the PR description. Fixed there now, too.

kennytm added a commit to kennytm/rust that referenced this pull request Mar 29, 2018
@kennytm
Rollup merge of rust-lang#49473 - joshtriplett:nonnull-size, r=stevek…
801deae 
…labnik

src/libcore/ptr.rs: Fix documentation for size of `Option<NonNull<T>>`

Seems more useful to say that it has the same size as `*mut T`.
@kennytm kennytm mentioned this pull request Mar 29, 2018
Merged
bors added a commit that referenced this pull request Mar 30, 2018
@bors
Auto merge of #49489 - kennytm:rollup, r=kennytm
d8a1bc7 
Rollup of 10 pull requests

- Successful merges: #49443, #49445, #49446, #49463, #49464, #49466, #49468, #49473, #49484, #49486
- Failed merges:
@bors bors merged commit 39fe29b into rust-lang:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@steveklabnik steveklabnik steveklabnik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Kimundi Kimundi

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshtriplett @steveklabnik @bors @kennytm @Kimundi