bootstrap: Remove the help fast path #49721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is rarely noticed, but when you have old submodules, not updating them will cause you run into rust-lang/cargo#4678.
ishitatsuyuki
changed the title
pietroalbini
added
the
S-waiting-on-review
|
Highfive failed to assign a reviewer. @Mark-Simulacrum? |
|
Seems reasonable. @bors r+ |
|
📌 Commit 4c51d47 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 6, 2018
…Mark-Simulacrum bootstrap: Remove the help fast path This is rarely noticed, but when you have old submodules, not updating them will cause you run into rust-lang/cargo#4678.
|
Er oops, @ishitatsuyuki mind resubmitting this PR from your own repo instead of the rust repo? |
|
Looks like it's already in a rollup, so I'll do that if the rollup get closed. |
1 similar comment
|
Looks like it's already in a rollup, so I'll do that if the rollup get closed. |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 7, 2018
…Simulacrum bootstrap: Remove the fast path This is rarely noticed, but when you have old submodules, not updating them will cause you run into rust-lang/cargo#4678. (Reopen of rust-lang#49721) r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rarely noticed, but when you have old submodules, not updating them will cause you run into rust-lang/cargo#4678.