Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Don't include private paths in all.html #50032

Merged
merged 1 commit into from Apr 17, 2018
Merged

rustdoc: Don't include private paths in all.html #50032

merged 1 commit into from Apr 17, 2018

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Apr 17, 2018

For example the std all.html includes references to the coresimd module which is a private implementation detail.

r? @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2018
@GuillaumeGomez
Copy link
Member

Good catch, thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 17, 2018

📌 Commit abded61 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 17, 2018
@GuillaumeGomez
Rollup merge of rust-lang#50032 - ollie27:rustdoc_all_private, r=Guil…
92d29c1 
…laumeGomez

rustdoc: Don't include private paths in all.html

For example the `std` [`all.html`](https://doc.rust-lang.org/nightly/std/all.html) includes references to the `coresimd` module which is a private implementation detail.

r? @GuillaumeGomez
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 17, 2018
Merged
bors added a commit that referenced this pull request Apr 17, 2018
@bors
Auto merge of #50033 - GuillaumeGomez:rollup, r=GuillaumeGomez
9379bcd 
Rollup of 4 pull requests

Successful merges:

 - #49699 (Removed 'proc' from the reserved keywords list)
 - #49966 (Multiple query search)
 - #50013 (Remove no longer necessary comparison to Vec::splice.)
 - #50032 (rustdoc: Don't include private paths in all.html)

Failed merges:
@bors bors merged commit abded61 into rust-lang:master Apr 17, 2018
@ollie27 ollie27 deleted the rustdoc_all_private branch April 17, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ollie27 @GuillaumeGomez @bors @rust-highfive