Add a ui test for an incorrect Result success type in a #[test] #50272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
4 tasks
nikomatsakis
approved these changes
Apr 27, 2018
| LL | / fn can_parse_zero_as_f32() -> Result<f32, ParseIntError> { //~ ERROR | ||
| LL | | "0".parse() | ||
| LL | | } | ||
| | |_^ `main` can only return types that implement `std::process::Termination` |
There was a problem hiding this comment.
hmm, that message is a bit off, isn't it?
There was a problem hiding this comment.
also, the span stinks =)
There was a problem hiding this comment.
but let's add it anyway and file a follow-up bug
|
@bors r+ rollup |
|
📌 Commit f0069b8 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 30, 2018
Add a ui test for an incorrect Result success type in a #[test] cc #48854 (comment) r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #48854 (comment)
r? @nikomatsakis