Fix ICE in assertion macro #50474
Merged
Fix ICE in assertion macro #50474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
pietroalbini
added
the
beta-nominated
|
cc @rust-lang/compiler Could someone review this? It's a beta regression which needs to be backported in the next ~36 hours or so if it's to be in time... |
|
@bors: r+ p=4 |
|
📌 Commit 39df223 has been approved by |
bors
added
S-waiting-on-bors
alexcrichton
added
the
beta-accepted
|
Added this PR to #50478. |
bors
added a commit
that referenced
this pull request
May 6, 2018
Fix ICE in assertion macro Fixes #50471. Needs beta-backport (stable-to-beta/nightly regression). * `panic` with single argument does not need escaping `{` and `}` * Instead of unescaping `\u{...}` manually, just use `escape_debug` in pprust
|
cc @nnethercote |
|
☀️ Test successful - status-appveyor, status-travis |
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
May 6, 2018
[beta] Process backports * #50419: rustdoc: Resolve nested `impl Trait`s * #50474: Fix ICE in assertion macro r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50471. Needs beta-backport (stable-to-beta/nightly regression).
panicwith single argument does not need escaping{and}\u{...}manually, just useescape_debugin pprust