-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Update docs for std::alloc to show how to turn on the system allocator #51974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here's a PR against the reference: rust-lang/reference#367 |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@rust-lang/libs, is this something we want to do? my understanding is that
because we want to switch to the system allocator. |
I think it’s fine to document the current reality as long as docs are clear that it is unspecified and expected to change in future versions. So rather than a note at the bottom I’d prefer leading with that, and then explaining what is current. |
I'd agree with @SimonSapin in that it should be fine to document reality so long as there's a lot of notes and caveats saying so and that it's subject to change (perhaps with links to tracking issues) |
Ping from triage @brson, any progress on this PR? |
Ping from triage, @brson: What is the status of this PR? |
Ping @brson, 1.28 will be released in a week, can you make the requested changes soon? |
Ping from triage @brson! We haven't heard from you in a while so I'm closing this PR for now. Please re-open it when you have time to work on it again. |
On nightly/beta the global allocator API is enabled, but jemalloc is still the default. This does not seem to be indicated in the documentation though. This change makes it clear that jemalloc is the default allocator for executables on Unixes and shows how to instead enable the system allocator.
If this pull is accepted it should be backported to beta. Somebody please tag it as appropriate.
r? @steveklabnik