rustc_codegen_llvm: replace the first argument early in FnType::new_vtable. #52089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
nagisa
reviewed
Jul 11, 2018
| .unwrap_or_else(|| { | ||
| bug!("FnType::new_vtable: non-pointer self {:?}", layout) | ||
| }).ty; | ||
| let fat_ptr_ty = cx.tcx.mk_mut_ptr(pointee); |
There was a problem hiding this comment.
This variable name is confusing, given that this is not a type of a fat pointer, but rather its data pointer only.
There was a problem hiding this comment.
Oh, never mind, I think I got it wrong myself lol.
|
@bors r+ |
|
📌 Commit ce94518 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 12, 2018
rustc_codegen_llvm: replace the first argument early in FnType::new_vtable. Fixes #51907 by removing the vtable pointer before the `ArgType` is even created. This allows any ABI to support trait object method calls, regardless of how it passes `*dyn Trait`. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
pietroalbini
added
beta-nominated
|
compiler team discussed. Since #51907 is a stable-to-stable regression, we decided we are better off letting the fix wait another ~6 weeks rather than put this into the beta, especially so close to when the beta is going to be cut for the next stable release. |
pnkfelix
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51907 by removing the vtable pointer before the
ArgTypeis even created.This allows any ABI to support trait object method calls, regardless of how it passes
*dyn Trait.r? @nikomatsakis