core: implement Clone for primitive types #5294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Mar 9, 2013
This makes `#[deriving_clone]` useful. I wasn't sure if a macro was the right way to do this, but it seems more maintainable than a series of repetitive `impl`s.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Lint unnamed address comparisons Functions and vtables have an insignificant address. Attempts to compare such addresses will lead to very surprising behaviour. For example: addresses of different functions could compare equal; two trait object pointers representing the same object and the same type could be unequal. Lint against unnamed address comparisons to avoid issues like those in rust-lang#69757 and rust-lang#54685. changelog: New lints: [`fn_address_comparisons`] [rust-lang#5294](rust-lang/rust-clippy#5294), [`vtable_address_comparisons`] [rust-lang#5294](rust-lang/rust-clippy#5294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
#[deriving_clone]useful.I wasn't sure if a macro was the right way to do this, but it seems more maintainable than a series of repetitive
impls.