Skip to content

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Aug 9, 2018

Enable the tidy check to forbid this!

Closes #53006

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2018
@alexcrichton
Copy link
Member Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned aturon Aug 9, 2018
@kennytm
Copy link
Member

kennytm commented Aug 9, 2018

This should be closing #53006 (I've fixed the PR description but the commit message still refers to #53005).

Enable the tidy check to forbid this!

Closes rust-lang#53006
@alexcrichton
Copy link
Member Author

Oops should be updated now!

@nrc
Copy link
Member

nrc commented Aug 9, 2018

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 9, 2018

📌 Commit 6c7473d has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 11, 2018
Deny future duplication of rustc-ap-syntax

Enable the tidy check to forbid this!

Closes rust-lang#53006
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 12, 2018
Deny future duplication of rustc-ap-syntax

Enable the tidy check to forbid this!

Closes rust-lang#53006
bors added a commit that referenced this pull request Aug 12, 2018
Rollup of 15 pull requests

Successful merges:

 - #52955 (Update compiler test documentation)
 - #53019 (Don't collect() when size_hint is useless)
 - #53025 (Consider changing assert! to debug_assert! when it calls visit_with)
 - #53059 (Remove explicit returns where unnecessary)
 - #53165 ( Add aarch64-unknown-netbsd target)
 - #53210 (Deny future duplication of rustc-ap-syntax)
 - #53223 (A few cleanups for rustc_data_structures)
 - #53230 ([nll] enable feature(nll) on various crates for bootstrap: part 4)
 - #53231 (Add let keyword doc)
 - #53240 (Add individual documentation for <integer>`.swap_bytes`/.`reverse_bits`)
 - #53253 (Remove unwanted console log)
 - #53264 (Show that Command can be reused and remodified)
 - #53267 (Fix styles)
 - #53273 (Add links to std::char::REPLACEMENT_CHARACTER from docs.)
 - #53283 (wherein we suggest float for integer literals where a float was expected)

Failed merges:

r? @ghost
@bors bors merged commit 6c7473d into rust-lang:master Aug 13, 2018
@alexcrichton alexcrichton deleted the deny-rustc-syntax branch August 29, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants